Skip to content

8280283: Dead compiler code found during the JDK-8272058 code review #28473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8280283: Dead compiler code found during the JDK-8272058 code review #28473

wants to merge 2 commits into from
+2 −21

Conversation

@anton-seoane
Copy link
Contributor

@anton-seoane anton-seoane commented Nov 24, 2025 •
edited by openjdk bot
Loading

This PR removes some dead code that was found during review for JDK-8272058.

target_addr_for_insn_or_null is never run with a ldrw to zr (i.e. a safepoint poll). This is just a remnant from global safepointing, before we moved to using thread-local handshakes. No safepoint polling code reaches this function. More information can be read in the original code review. Additionally, I have run tiers 1-6 to make sure this path did not exercise.

This changeset also cleans up the unused is_nop function, following the comments in the issue. Other dead code mentioned there has since been long disappered.

Testing: passes tiers 1-4

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280283: Dead compiler code found during the JDK-8272058 code review (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28473/head:pull/28473
$ git checkout pull/28473

Update a local copy of the PR:
$ git checkout pull/28473
$ git pull https://git.openjdk.org/jdk.git pull/28473/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28473

View PR using the GUI difftool:
$ git pr show -t 28473

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28473.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2025

👋 Welcome back aseoane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8280283: dead compiler code found during the JDK-8272058 code review 8280283: dead compiler code found during the JDK-8272058 code review Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025 •
edited
Loading

@anton-seoane The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@anton-seoane anton-seoane changed the title 8280283: dead compiler code found during the JDK-8272058 code review 8280283: Dead compiler code found during the JDK-8272058 code review Nov 24, 2025
@anton-seoane
Copy link
Contributor Author

anton-seoane commented Nov 25, 2025

/label add hotspot-compiler
/label remove hotspot

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@anton-seoane
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@anton-seoane
The hotspot label was successfully removed.

@anton-seoane
Copy link
Contributor Author

anton-seoane commented Nov 25, 2025

/touch

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@anton-seoane The pull request is being re-evaluated and the inactivity timeout has been reset.

@anton-seoane
Copy link
Contributor Author

anton-seoane commented Nov 25, 2025

/issue add 8280283

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@anton-seoane This issue is referenced in the PR title - it will now be updated.

@anton-seoane anton-seoane marked this pull request as ready for review November 25, 2025 09:05
@anton-seoane
Copy link
Contributor Author

anton-seoane commented Nov 25, 2025

/touch

Hey bot, please find my issue

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

@anton-seoane The pull request is being re-evaluated and the inactivity timeout has been reset.

@anton-seoane anton-seoane changed the title 8280283: Dead compiler code found during the JDK-8272058 code review 8280283: Dead compiler code found during the JDK-8272058 code review Nov 25, 2025
@anton-seoane anton-seoane changed the title 8280283: Dead compiler code found during the JDK-8272058 code review 8280283: Dead compiler code found during the JDK-8272058 code review Nov 25, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2025

Webrevs

@anton-seoane
Copy link
Contributor Author

anton-seoane commented Nov 26, 2025

Pinging @bulasevich @theRealAph, as they were in the original code review and discussed about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hotspot-compiler [email protected] rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@anton-seoane